Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Util.replaceMacro instead of our custom replacement logic #198

Merged
merged 2 commits into from
Aug 26, 2017
Merged

Use Util.replaceMacro instead of our custom replacement logic #198

merged 2 commits into from
Aug 26, 2017

Conversation

carlossg
Copy link
Contributor

Behavior change: when a var is not defined it is not replaced

ie.

${key1} or ${key2} or ${key3} -> value1 or value2 or ${key3}

@carlossg
Use Util.replaceMacro instead of our custom replacement logic
6749e1e 
Behavior change: when a var is not defined it is not replaced

ie.
${key1} or ${key2} or ${key3} -> value1 or value2 or ${key3}
@carlossg carlossg requested a review from iocanel August 14, 2017 10:38
@carlossg carlossg merged commit 7d92eaf into master Aug 26, 2017
@Vlatombe Vlatombe deleted the substitute branch July 10, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinthepa marvinthepa marvinthepa approved these changes

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossg @marvinthepa @iocanel