New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Util.replaceMacro instead of our custom replacement logic #198

Merged
merged 2 commits into from Aug 26, 2017

Conversation

Projects
None yet
3 participants
@carlossg

carlossg commented Aug 14, 2017

Behavior change: when a var is not defined it is not replaced

ie.

${key1} or ${key2} or ${key3} -> value1 or value2 or ${key3}
Use Util.replaceMacro instead of our custom replacement logic
Behavior change: when a var is not defined it is not replaced

ie.
${key1} or ${key2} or ${key3} -> value1 or value2 or ${key3}

@carlossg carlossg requested a review from iocanel Aug 14, 2017

@carlossg carlossg merged commit 7d92eaf into master Aug 26, 2017

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment