/kubernetes-plugin forked from carlossg/jenkins-kubernetes-plugin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-50913] Do not pass arguments to jnlp container #315

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Reviewers

@Vlatombe Vlatombe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@carlossg @Vlatombe
@carlossg

carlossg commented Apr 24, 2018 •
edited

They haven't been needed for a while and can't be merged easily from parent to children

Fixes regression introduced in #305
@carlossg
[JENKINS-50913] Do not pass arguments to jnlp container 
They haven't been needed for a while and can't be merged easily from parent to children
170b51e

@carlossg carlossg merged commit 6d4508d into master Apr 24, 2018
1 check passed

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@carlossg carlossg deleted the JENKINS-50913 branch Apr 24, 2018

scoheb added a commit to scoheb/jenkins-1 that referenced this pull request May 24, 2018

@scoheb
Amend arguments if none passed to run-jnlp-client 
As of version 1.6.0 of the Jenkins Kubernetes plugin,
args are no longer passed to jnlp container if not present in containerTemplate

See jenkinsci/kubernetes-plugin#315

This is made worse if using Declarative pipeline and specifying yaml for the podTemplate.
since ${computer.*} is not resolvable.

To workaround this, we use JENKINS_SECRET and JENKINS_NAME for launcher arguments

See https://gist.github.com/scoheb/f29d263c240e8880648b920240635ed6 for an example Jenkinsfile
ac63047

@scoheb scoheb referenced this pull request May 24, 2018

Merged

Amend arguments if none passed to run-jnlp-client #614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment