[JENKINS-57116] Fix empty yamls introduced on upgrade to 1.15.1 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although I don't see were it could come from Added logging to debug it
Remove items with empty strings Add tests
carlossg
changed the title
|
Ok, figured it out and fixed it. The <yamls>
<string></string>
</yamls> |
richbg
reviewed
May 9, 2019
| @@ -47,7 +47,7 @@ | |||
| <java.level>8</java.level> | |||
| <jenkins.version>2.138.4</jenkins.version> | |||
| <no-test-jar>false</no-test-jar> | |||
| <surefire.rerunFailingTestsCount>1</surefire.rerunFailingTestsCount> | |||
| <surefire.rerunFailingTestsCount>0</surefire.rerunFailingTestsCount> | |||
There was a problem hiding this comment.
@carlossg was there a flaky test we were using the rerun option for?
There was a problem hiding this comment.
there have been some flaky tests in the past, but I'd rather avoid rerunning and fix them, and we have 2 different builds happening
richbg
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I don't see were it could come from
Added logging to debug it