[JENKINS-58724] Update existing logger to display current run #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
changed the title
jglick
reviewed
Jul 30, 2019
| @@ -47,12 +47,14 @@ public KubernetesComputer(KubernetesSlave slave) { | |||
| @Override | |||
| public void taskAccepted(Executor executor, Queue.Task task) { | |||
| super.taskAccepted(executor, task); | |||
| LOGGER.fine(" Computer " + this + " taskAccepted"); | |||
| Queue.Executable exec = executor.getCurrentExecutable(); | |||
| LOGGER.log(Level.FINE, " Computer " + this + " accepted task " + exec); | |||
There was a problem hiding this comment.
BTW sub-INFO logger calls should either use the Supplier overload or message formats
LOGGER.log(Level.FINE, " Computer {0} accepted task {1}", new Object[] {this, exec});to avoid string concatenation when unused. Unlikely to matter much in this case.
There was a problem hiding this comment.
I opened PR 564 for this because it is already merged.
There was a problem hiding this comment.
#564 that is. FYI: GitHub has nice handling (hover tips, backlinks) for several kinds of URLs when pasted directly into GH-flavored Markdown, but not when used in a Markdown link.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-58724