JENKINS-24827 Port hpi:run to jetty 8.x #12
Conversation
…-- doesn't boot correctly, perhaps due to classpath issues. See JENKINS-24827 for more information.
- Update jetty to latest 8.x - Expose jetty packages to webapp as it is required for jndi initial factory - Rename org.mortbay.jetty to org.eclipse.jetty
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Argh!!! ok we need to figure out how to get the bot to actually correctly identify cloudbees employees some how.... |
|
Maybe you could look up if the pull request creator is part of the Cloudbees GH organization? |
|
@Vlatombe ha! that is what we were doing, but that was giving us a lot of false negatives. I suspect I am going to have to resort to a hard-coded list of bees :-( |
|
Given we are just soon to require servlet 3.x I wonder if this should go futher than jetty 8 which is only 3.0? |
|
I could give a shot to Jetty 9.x if this gets some traction. |
| sp.setName("HUDSON_HOME"); | ||
| sp.setValue(jenkinsHome.getAbsolutePath()); | ||
| sp.setIfNotSetAlready(); | ||
| setSystemPropertyIfEmpty("HUDSON_HOME",jenkinsHome.getAbsolutePath()); |
There was a problem hiding this comment.
should this also set JENKINS_HOME?
| sp.setIfNotSetAlready(); | ||
| // set JENKINS_HOME | ||
| setSystemPropertyIfEmpty("HUDSON_HOME",jenkinsHome.getAbsolutePath()); | ||
| setSystemPropertyIfEmpty("JENKINS_HOME",jenkinsHome.getAbsolutePath()); |
There was a problem hiding this comment.
this does break backwards compatibility with anyone who sets HUDSON_HOME and uses hpi:run - as JENKINS_HOME will take precedence over HUDSON_HOME (IIRC)
I'm inclined to say if you set one you set both - or only set JENKINS_HOME.
But we should be encouraging devs to use JENKINS_HOME as HUDSON is long dead :-)
There was a problem hiding this comment.
I'll just remove HUDSON_HOME then.
|
🐝 |
|
🐝 without understanding most of the details. I have to assume you have tested this interactively with a variety of plugins, as there are a lot of special cases buried in this mojo that can regress easily, and there is zero test coverage. |
JENKINS-24827 Port hpi:run to jetty 8.x
This pull request replaces #11
The notation
has been deprecated by the jetty-maven-plugin and is now exposed as
So the plugins parent should be updated to use this new structure.