Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warning if using deprecated java.level with new enough parent POM #320

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

basil
Copy link
Member

@basil basil commented Mar 30, 2022

Tested manually with jenkinsci/plugin-pom#522

@basil basil requested a review from jglick March 30, 2022 04:02
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could do this with a POM profile, but since we have a place in Java code to do it, may as well!

@basil
Copy link
Member Author

basil commented Mar 30, 2022

I couldn't find a way to do this with a POM profile. Enforcer has a requireProperty rule, but here we want to do the opposite (ban a property).

@basil
Copy link
Member Author

basil commented Mar 30, 2022

I think you could do this with a POM profile

Actually I think not. From the Maven documentation on profiles:

Supported variables are system properties like ${user.home} and environment variables like ${env.HOME}. Please note that properties and values defined in the POM itself are not available for interpolation here.

So yeah this is just not possible.

@basil basil merged commit 5943af8 into jenkinsci:master Mar 30, 2022
@basil basil deleted the java-level branch March 30, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants