New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows to the build #422

Merged

basil merged 1 commit into jenkinsci:master from jtnord:windows-build

Jan 10, 2023

Member

jtnord commented Jan 10, 2023 •

edited

Loading

Adding windows to the mix as

we have developers consuming hpi plugin on windows so we want to run the ITs on windows to ensure we do not break windows plugin development
we have developers contributing to this plugin using windows and have observed some windows specific issues in the plugin build.

build log demonstrates that #420 was not complete.

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue


          Add windows to the build

7a943ef

jtnord added the internal label

jtnord marked this pull request as draft

January 10, 2023 13:21

jtnord marked this pull request as ready for review

January 10, 2023 13:46

jtnord requested a review from basil

January 10, 2023 13:46

basil approved these changes

View reviewed changes

basil merged commit 9c95c05 into jenkinsci:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment