Remove use of Maven Wagon #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Jun 7, 2023
Comment on lines
-328
to
-332
| <dependency> | ||
| <groupId>com.github.stephenc.wagon</groupId> | ||
| <artifactId>wagon-gitsite</artifactId> | ||
| <version>0.5</version> | ||
| </dependency> |
There was a problem hiding this comment.
https://github.com/stephenc/wagon-gitsite has not been updated since 2014, so this is a dead end.
MarkEWaite
approved these changes
Jun 7, 2023
|
Deployed successfully to http://jenkinsci.github.io/maven-hpi-plugin/ |
|
Hrmm, the generated site seems to be missing the Mojo pages. But I see the same problem when running |
Merged
|
--> #500 |
|
http://jenkinsci.github.io/maven-hpi-plugin/hpi-mojo.html looks correct now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this page Maven Wagon is deprecated. This PR eliminates use of Maven Wagon at release time, replacing it with a GitHub Action that uploads the generated site to GitHub Pages on every clean build of the main branch.
Testing done
I am using this workflow successfully in Job DSL plugin. If there are any issues with this PR I will fix them after merging this PR.
Fixes #492