Fix GH ribbon on site by updating maven-fluido-skin and keeping track of it #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
commented
Jul 4, 2023
Comment on lines
-13
to
-16
| <poweredBy> | ||
| <logo name="Built by Maven" href="http://maven.apache.org/" img="images/logos/maven-feather.png" /> | ||
| </poweredBy> | ||
|
|
There was a problem hiding this comment.
That's the default footer, which doesn't need to be specified separately.
timja
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of maven-fluido-skin pulls in a resource from AWS, which is no longer accessible, causing:
The change proposed updates maven-fluido-skin to restore the ribbon, and keeps track of further updates:
