Update link and description to match Jenkins 2. Source of confusion i… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n ticket JENKINS-34743
|
The reason for the check failure isn't clear to me, is there a problem with the PR, or was there an issue with the test at the time? Admittedly this was about 5 minutes into my first look at any Jenkins source, but it seems like an innocuous enough change that it wouldn't break the build. |
|
It seems to have nothing to do with your changes. |
|
Same goal here than PR #67 |
|
Like #67 as far as the plugin can be used in 1.x and 2.x we should use a parameter for URL and compute it based on the version of Jenkins |
|
Superseded by #82 which keeps the compatibility for Jenkins 1.x users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n ticket JENKINS-34743