Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65175] Revert ini4j upgrade #185

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 16, 2021

JENKINS-65175: reverts #157.

The cleaner fix would likely be that suggested in a duplicate JENKINS-66997:

diff --git a/src/main/java/hudson/plugins/mercurial/MercurialSCM.java b/src/main/java/hudson/plugins/mercurial/MercurialSCM.java
index e11cd3b..9d8b37f 100755
--- a/src/main/java/hudson/plugins/mercurial/MercurialSCM.java
+++ b/src/main/java/hudson/plugins/mercurial/MercurialSCM.java
@@ -813,6 +813,7 @@ public class MercurialSCM extends SCM implements Serializable {
                 if (hgrc.exists()) {
                     try (InputStream is = hgrc.read()) {
                         Ini hgrcIni = new Ini(is);
+                        hgrcIni.getConfig().setEscape(false);
                         hgrcIni.put("paths", "default", getSource(env));
                         try (OutputStream os = hgrc.write()) {
                             hgrcIni.store(os);

plus some other points where ini4j is used. However, I do not have a self-contained test case to guard against regression, so simply reverting to the last library version thought to be unproblematic seems safer.

@jglick jglick added the bug label Nov 16, 2021
@@ -108,7 +108,7 @@
<dependency>
<groupId>org.ini4j</groupId>
<artifactId>ini4j</artifactId>
<version>0.5.4</version>
<version>0.5.2</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe needs some comment for future update attempts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept that in the Dependabot config.

@jglick jglick merged commit 5b7d524 into jenkinsci:master Nov 16, 2021
@jglick jglick deleted the ini4j-JENKINS-65175 branch November 16, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants