Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(security) Upgrading ini4j version. #238

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gounthar
Copy link
Contributor

…ass of org.ini4j before v0.5.4 allows attackers to cause a Denial of Service (DoS) via unspecified vectors.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

An issue in the fetch() method in the BasicProfile class of org.ini4j before v0.5.4 allows attackers to cause a Denial of Service (DoS) via unspecified vectors.

…ass of org.ini4j before v0.5.4 allows attackers to cause a Denial of Service (DoS) via unspecified vectors.
@gounthar gounthar requested a review from a team as a code owner October 18, 2022 19:00
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No version ranges please!

@jglick jglick disabled auto-merge October 18, 2022 19:43
@jglick
Copy link
Member

jglick commented Oct 18, 2022

Also see #185. the reason why Dependabot did not offer this: 0.5.4 is broken without further changes to the plugin.

@gounthar
Copy link
Contributor Author

Thanks a lot for the explanation.

@KanakamedalaSiri
Copy link

When these changes are going to get merged and released? waiting for ini4j version upgrade as it was marked vulnerable by our security team. Any help is greatly appreciated.

@MarkEWaite
Copy link
Contributor

When these changes are going to get merged and released? waiting for ini4j version upgrade as it was marked vulnerable by our security team. Any help is greatly appreciated.

They are unlikely to be merged or released until someone adopts the plugin, makes the changes noted in #238 (comment) and tests those changes. If your organization depends on the Mercurial plugin, you should persuade your organization to let you or someone else in your organization adopt the plugin, learn its implementation, make the changes, test the changes, and release the plugin.

If your organization is not willing to adopt the plugin, then you may want to tell the security team in your organization that their security scanner is probably reporting a false positive. Security teams commonly flag a binary as vulnerable if it includes a dependency, whether or not the dependency is used in a way that makes it vulnerable.

If your security team has a way to exercise a vulnerability in the Mercurial plugin for Jenkins, please follow the Jenkins security vulnerability reporting guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants