Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-19090 can't delete the project #1

Merged
merged 1 commit into from Dec 1, 2016

Conversation

escoem
Copy link
Collaborator

@escoem escoem commented Nov 4, 2016

load(InputStream) method leave the stream open after using it so I just add a finally block for closing it. That open stream could leave the file opened.

java.nio.file.FileSystemException: D:\00_CI\00_Jenkins\jobs\test\mttr.properties: The process cannot access the file because it is being used by another process.

@zhaozhiming Are you still maintaining the plugin?

@reviewbybees cc/ @aheritier

@ghost
Copy link

ghost commented Nov 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@aheritier
Copy link
Member

🐝

@Dohbedoh
Copy link

Dohbedoh commented Nov 9, 2016

🐝 LGTM

@zhaozhiming
Copy link
Member

@escoem Sorry for so late to see this PR. Actually I didn't pay attention to this project for a long time.
I'm very happy for using my plugin and I will merge this PR. It look good to me.
Thanks.

@zhaozhiming zhaozhiming merged commit 86a0918 into jenkinsci:master Dec 1, 2016
@escoem
Copy link
Collaborator Author

escoem commented Dec 1, 2016

Thanks @zhaozhiming I can help you also to adapt the plugin to the last parent pom version, just create a JIRA ticket and assign to me.

@zhaozhiming
Copy link
Member

@escoem I try to publish the new version to jenkins, but it report errors when I upload the files.
I don't know the reason whether my plugin version is too old.
Maybe I need your help to publish it.
You said to create a JIRA ticket, what is the JIRA url?
Maybe I could add you to this project members so you can help me to publish it, is it OK?
Thanks.

upload errors:

[INFO] Uploading: http://maven.jenkins-ci.org:8081/content/repositories/releases/org/jenkins-ci/plugins/mttr/1.2/mttr-1.2.pom
[INFO] 2/2 KB
[INFO]
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time: 5:14.744s
[INFO] [INFO] Finished at: Fri Dec 02 22:38:25 HKT 2016
[INFO] [INFO] Final Memory: 57M/548M
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.6:deploy (default-deploy) on project mttr: Failed to deploy artifacts: Could not transfer artifact org.jenkins-ci.plugins:mttr:hpi:1.2 from/to maven.jenkins-ci.org (http://maven.jenkins-ci.org:8081/content/repositories/releases): The target server failed to respond -> [Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[INFO] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

@escoem
Copy link
Collaborator Author

escoem commented Dec 2, 2016

Hello @zhaozhiming I have created https://issues.jenkins-ci.org/browse/JENKINS-40193 to upgrade the plugin parent pom version in other PR

@zhaozhiming
Copy link
Member

OK, thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants