Fixing NPE while running a Maven build.

java.lang.NullPointerException at com.chikli.hudson.plugin.naginator.NaginatorActionFactory.createFor(NaginatorActionFactory.java:20) at hudson.model.Run.getTransientActions(Run.java:351)
jenkinsci · Apr 17, 2014 · 6789567 · 6789567 · jglick · Dec 23, 2014
1 parent d1854c0
commit 6789567
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/com/chikli/hudson/plugin/naginator/NaginatorActionFactory.java b/src/main/java/com/chikli/hudson/plugin/naginator/NaginatorActionFactory.java
@@ -15,11 +15,13 @@
 @Extension
 public class NaginatorActionFactory extends TransientBuildActionFactory {
 
+    @SuppressWarnings("rawtypes")
     @Override
     public Collection<? extends Action> createFor(Run target) {
-        if (target.getResult().isWorseThan(Result.SUCCESS)) {
+        Result result = target.getResult();
+        if (result != null && result.isWorseThan(Result.SUCCESS)) {
             return Collections.singleton(new NaginatorRetryAction());
         }
-        return Collections.EMPTY_LIST;
+        return Collections.emptyList();
     }
 }