Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multibranch jobs after Jenkins 2.266 #10

Merged
merged 5 commits into from
Sep 28, 2021

Conversation

eoc-ross
Copy link
Contributor

Fixing broken compatiblity with Jenkins v2.268 with an ugly hack. Related jenkins issue https://issues.jenkins.io/browse/JENKINS-65608.

Jenkins v2.268 upgraded spring security from org.acegisecurity to org.springframework.security.
Relevant change: jenkinsci/jenkins@a9ca5ef
@akomakom akomakom changed the title Patch 1 Support multibranch jobs after Jenkins 2.266 Sep 21, 2021
@eoc-ross
Copy link
Contributor Author

It looks like the only option was to bump jenkins version... Still catching the old acegisecurity exception, should I remove it?

@akomakom
Copy link
Contributor

I think it's safe to remove, according to the docs. I'd just test it locally for whatever multibranch types you have installed.

@eoc-ross
Copy link
Contributor Author

@akomakom
Copy link
Contributor

@eoc-ross confirmed that it also works with GitHub Branch Source

@eoc-ross eoc-ross closed this Sep 28, 2021
@akomakom
Copy link
Contributor

@eoc-ross did you intend to close?

@eoc-ross
Copy link
Contributor Author

Ops, my bad... Handling too many things at once

@eoc-ross eoc-ross reopened this Sep 28, 2021
@akomakom
Copy link
Contributor

No worries

@akomakom akomakom merged commit f71762c into jenkinsci:master Sep 28, 2021
@akomakom
Copy link
Contributor

Thanks @eoc-ross !
I'll do some cleanup and make 1.7

@akomakom
Copy link
Contributor

Version 1.7 is now available and seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants