Change references to pkg.jenkins-ci.org to pkg.jenkins.io. #55
Conversation
|
|
|
LGTM 👍 |
| export RPM_WEBDIR=/var/www/pkg.jenkins-ci.org.staging/redhat${RELEASELINE} | ||
| export SUSE_WEBDIR=/var/www/pkg.jenkins-ci.org.staging/opensuse${RELEASELINE} | ||
| export DEB_WEBDIR=/var/www/pkg.jenkins-ci.org.staging/debian${RELEASELINE} | ||
| export RPM_WEBDIR=/var/www/pkg.jenkins.io.staging/redhat${RELEASELINE} |
There was a problem hiding this comment.
This part of the changes will break things unless accompanied by a change to this script
There was a problem hiding this comment.
Don't merge 'til after jenkinsci/packaging#55 is merged, and probably make sure we've got a pre-staged /var/www/pkg.jenkins.io.staging ready too.
|
@abayer Is this intended to only apply to pre-jenkins 2 packaging? |
|
Both. Lemme guess, I forgot that 2.x is on another branch. =) |
|
@abayer Nah, I assumed we were just going to merge/cherry-pick stuff if both needed it, was curious though. |
|
Tough luck, I did a PR there too! |
|
@abayer How much do we want to redirect to jenkins.io vs. jenkins-ci.org? There are a bunch of other references: https://github.com/jenkinsci/packaging/search?utf8=%E2%9C%93&q=jenkins-ci.org Not sure what the impact would be of changing all them though (case-by case basis there, some might be safest to leave in place). |
|
|
@rtyler That gif makes my eyes bleed! 😆 |
|
@svanoort Piecemeal! There are probably some other places (i.e., bare references to |
|
@abayer Well, I guess that makes sense -- those other usages do need to be looked at. 🐛 for not changing the .htaccess files, in the subdirectories here, for example: https://github.com/jenkinsci/packaging/tree/master/env/release |
|
Those refer to |
|
@abayer http://mirrors.jenkins.io/ exists -- I think if we change one, we should be changing both in the same PR. Doing it this way is a bug, because then we're tying two of our separate domains together (and make the system more brittle -- any issues in the original site will potentially hit jenkins.io). Whatever the opshead's version of a bug is, it's that. |
|
FWIW, the |
|
That's somewhat better that alternatives I could see, but I still think they should be changed in step (it doesn't make sense to do otherwise). |
Not touching issues.jenkins-ci.org or wiki.jenkins-ci.org since those don't exist in jenkins.io yet, and leaving the OS X "org.jenkins-ci" stuff around since I don't know what the impact would be of changing that.
|
Happy now, @svanoort? Huh? Huh? =) |
|
@abayer I 🐝 lieve I can get behind this! 👍 (yes. 😄 ) |
|
So this should be merged yeah? |
|
@rtyler Double checking that we don't have someone wanting to freeze packaging for a release, then yes. |
|
@svanoort this code won't get execercised until @kohsuke creates a weekly release, or @olivergondza creates an RC right? |
|
@rtyler Correct. Also I just merged this into the Jenkins 2 branch as well, so we're covered there. |
cc @reviewbybees, @rtyler, @kohsuke, @daniel-beck