[JENKINS-55400] Provide an extension to notify input event

[LinuxSuRen]

No description provided.

[LinuxSuRen]

ping @jenkinsci/code-reviewers

I'm looking for some reviewing. Thanks.

[daniel-beck]

It's unclear what's special about input. Wouldn't think be useful for all types of pipeline steps?

[LinuxSuRen]

input is an interactive step. If other system wants to integrate with Jenkins pipeline. It's hard to aware of this interactive step.

[LinuxSuRen]

@daniel-beck I did some new changes. Notifying all status should be more helpful for who wants to integrate this to their system.

Open questions:
I want to give a simple implement for current extension. For example, a simple input request notificatioin base on HTTP protocol. I figure out two solutions:

• create a new plugin for that
• provide this as build-in

[LinuxSuRen]

ping @dwnusbaum @daniel-beck

[LinuxSuRen]

Anyone could help me to review this?

[dwnusbaum]

Added some minor comments. It would help to see some proposed uses of the new extension point to know what it should like.

[LinuxSuRen]

@dwnusbaum Are there anything that I need to modify? It's been a long time.

[LinuxSuRen]

Do I need to make any changes?

[runzexia]

@dwnusbaum @daniel-beck
Can we land it?

[runzexia]

Any progress?

[jglick]

In principle sounds fine. Is there a downstream PR demonstrating this being used to implement something useful?

[jglick]

Note that you can get mostly the same effect using existing APIs such as GraphListener, so this is not exactly necessary—it would be a convenience.

[LinuxSuRen]

I can send an email to someone if I can get the notification of input event. This is my main purpose here.

[dwnusbaum]

The main thing I would like to see here before merging is some new tests, but ideally also a downstream PR of an example consumer.

[jglick]

Merge with master as in #44.

I can send an email to someone if I can get the notification of input event.

Likely possible without any new API. If GraphListener says there is an input step, it started (you can get the message via ArgumentsAction). When the step completes (i.e., there is a new head with the input StepNode as a parent), you can check InputSubmittedAction to see if and how it was approved; or, if cancelled, check ErrorAction for FlowInterruptedException with Rejection.

[LinuxSuRen]

@jglick As you said that it's possible to do it by a bunch of code lines. But it's complicated especially for a person who still does not familiar with those API. I would suggest that giving a high-level extension point.

But still, I need to thanks you for providing the tech details of it.

[LinuxSuRen]

ping @jenkinsci/code-reviewers

[daniel-beck]

Code reviewers will be unable to merge, so these pings don't accomplish what you want.