Support withChecks #48
Open
+296
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrginglymus
force-pushed
the
with-checks
branch
from
3bce6ef
to
be273e9
Compare
mrginglymus
force-pushed
the
with-checks
branch
from
678eb47
to
40d51a3
Compare
|
I was going to add a test for checking that password parameters are masked, but that appears not to be expected behaviour; is that correct? |
Password parameters are a mess. See #16 and https://issues.jenkins.io/browse/JENKINS-43814. |
|
Why do you need to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of known todos:
It may also be that this is entirely the wrong way to do this, and that once #33 is in we can implement it from the checks-api end.