[JENKINS-42082] Verify that you can put TEST in an env var name #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abayer
commented
Jul 6, 2017
abayer
commented
- JENKINS issue(s):
- JENKINS-42082
- Description:
- Just verifying that this isn't an actual bug, at least as of now.
- Documentation changes:
- n/a
- Users/aliases to notify:
- @reviewbybees
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
rsandell
approved these changes
Jul 7, 2017
| steps { | ||
| echo "TEST_VAR is ${TEST_VAR}" | ||
| echo "VAR_TEST is ${VAR_TEST}" | ||
| } |
There was a problem hiding this comment.
Just to be safe, should add
sh "echo SH_TEST_VAR is $TEST_VAR"
sh "echo SH_VAR_TEST is $VAR_TEST"
or similar.
rsandell
approved these changes
Jul 10, 2017
| @@ -37,6 +37,8 @@ pipeline { | |||
| steps { | |||
| echo "TEST_VAR is ${TEST_VAR}" | |||
| echo "VAR_TEST is ${VAR_TEST}" | |||
| sh 'echo "TEST_VAR from shell is ${TEST_VAR}"' | |||
| sh 'echo "VAR_TEST from shell is ${VAR_TEST}"' | |||
There was a problem hiding this comment.
Well, the ${} are valid in bash but in this case unnecessary.
It might cause confusion that groovy is expected to expand it, at least I had to read it three times to get that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.