Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-46597] Further handling of serializability issues #218

Merged
merged 1 commit into from Nov 15, 2017

Conversation

abayer
Copy link
Member

@abayer abayer commented Nov 13, 2017

  • JENKINS issue(s):
  • Description:
    • Specifically: the checkout step returns a TreeMap, so let's make sure we never have a variable assigned directly to that return value. Probably want to change checkout to return a HashMap in the
      future, but we'll cross that bridge later. We can't actually test this normally because our core and workflow-scm-step versions are too old to have that functionality, but I did verify it by hand
    • Also updated workflow-cps dependency so that we can be sure BooleanClosureWrapper serialization issues won't crop up, letting us write more things as .every or .any.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
    • @reviewbybees

Specifically: the checkout step returns a TreeMap, so let's make sure
we never have a variable assigned directly to that return
value. Probably want to change checkout to return a HashMap in the
future, but we'll cross that bridge later.

Also updated workflow-cps dependency so that we can be sure
BooleanClosureWrapper serialization issues won't crop up, letting us
write more things as .every or .any.
@abayer abayer added this to the 1.2.5 milestone Nov 13, 2017
@ghost
Copy link

ghost commented Nov 13, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

@abayer abayer merged commit 86d6615 into jenkinsci:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants