JENKINS-52744 Showing meaningful error when an environment variable i… #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not declared properly
…s not declared properly
…s not declared properly
joseblas
requested review from
abayer and
rsandell
and removed request for
abayer
joseblas
changed the title
abayer
reviewed
Dec 17, 2018
...on/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy
Outdated
Show resolved
Hide resolved
…clared due to its value
abayer
reviewed
Dec 19, 2018
| @@ -455,7 +455,7 @@ class ModelInterpreter implements Serializable { | |||
| "${k}=${v.call()}" | |||
| }catch (NullPointerException e){ | |||
|
|
|||
| throw new IllegalArgumentException(format("Invalid var declared in environment: %s", k)) | |||
| throw new IllegalArgumentException(format("Invalid variable (%s) declared in environment; There are some problems with its value", k)) | |||
There was a problem hiding this comment.
So in practice, this is only going to show up if there's a reference to a non-existent variable in the value, right? Hence the NullPointerException - so in that case, we could probably be more specific and say something like One or more variables in its value do not exist?
Also, this should go in Messages.properties so that it can be localized.
There was a problem hiding this comment.
I don't want to narrow that much the error, what if another issue comes up as NPE?
abayer
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s not declared properly