New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-52744 Showing meaningful error when an environment variable i… #309
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f74d5f7
JENKINS-52744 Showing meaningful error when an environment variable i…
joseblas 29087b6
JENKINS-52744 Showing meaningful error when an environment variable i…
joseblas bc918d5
JENKINS-52744 Showing meaningful error when an environment variable i…
joseblas 8f7a61e
JENKINS-52744 changing text for errors when an invalid variable is de…
joseblas 0f7faa7
JENKINS-52744 Added localized message and changed
joseblas 2c9f390
JENKINS-52744 Added localized message and changed
joseblas File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in practice, this is only going to show up if there's a reference to a non-existent variable in the value, right? Hence the
NullPointerException
- so in that case, we could probably be more specific and say something likeOne or more variables in its value do not exist
?Also, this should go in
Messages.properties
so that it can be localized.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to narrow that much the error, what if another issue comes up as NPE?