[FIXED JENKINS-37823] Added "wrappers" section. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
|
🐝 |
|
|
||
| pipeline { | ||
| agent none | ||
| wrappers { |
There was a problem hiding this comment.
is this the name we want to go with?
|
Very nice - not 100% sold on the name "wrappers" but that is a minor thing. Can this be done at stage level too potentially? |
Conflicts: pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
|
LGTM |
rsandell
reviewed
Nov 1, 2016
| * | ||
| * @author Andrew Bayer | ||
| */ | ||
| public class WrappersToMapTranslator implements MethodMissingWrapper, Serializable { |
There was a problem hiding this comment.
I'm starting to see a lot of similar translators, we should extract common code into something that can be inherited and reused instead of copy and paste.
|
🐝 |
Conflicts: pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-37823
Trying to figure out what more tests are needed - note that this doesn't accept the
wrapstep, since it requires anodecontext and we explicitly reject any step that requires anode.cc @reviewbybees esp @stephenc @rsandell
Also cc @kuhnroyal since I know you're interested in this functionality. =)