[JENKINS-70808] Add a specific isRestartable method that accept a sta… #596

Dohbedoh · 2023-03-16T05:42:11Z

JENKINS issue(s):
- JENKINS-70808
Description:
- Add a method to specifically check if a stage is restartable that will return as soon as one is found and will not check the status of other irrelevant stages. To be consumed downstream by blueocean-pipeline-api-impl at https://github.com/jenkinsci/blueocean-plugin/blob/49440310221d3e68040c0a46842b8a91d0a577be/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineNodeImpl.java#L189-L193.
Users/aliases to notify:
- @olamy

…ge name

Signed-off-by: Olivier Lamy <olamy@apache.org>

…d and cached then future usage will be really quick... add TODO for using jenkinsci/pipeline-model-definition-plugin#596 Signed-off-by: Olivier Lamy <olamy@apache.org>

jglick · 2023-03-16T13:10:31Z

...org/jenkinsci/plugins/pipeline/modeldefinition/actions/RestartDeclarativePipelineAction.java

+                    for (ModelASTStage s : stages.getStages()) {
+                        if(s.getName().equals(stageName)) {
+                            return !Utils.stageHasStatusOf(s.getName(), execution,
+                                StageStatus.getSkippedForFailure(), StageStatus.getSkippedForUnstable());


So a failed/unstable stage is not restartable? The logic here is unclear. Is this just a copy / adaptation of code elsewhere?

@jglick it is the same logic as isRestartable() but specific to a single stage.

olamy · 2023-03-17T01:18:01Z

might need to take into account 821aabd

[JENKINS-70808] Add a specific isRestartable method that accept a sta…

0ae6dca

…ge name

olamy added a commit to jenkinsci/blueocean-plugin that referenced this pull request Mar 16, 2023

add TODO for using jenkinsci/pipeline-model-definition-plugin#596

1c5a1aa

Signed-off-by: Olivier Lamy <olamy@apache.org>

[JENKINS-70808] Add test

a3f80da

jglick reviewed Mar 16, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-70808] Add a specific isRestartable method that accept a sta… #596

[JENKINS-70808] Add a specific isRestartable method that accept a sta… #596

Dohbedoh commented Mar 16, 2023

jglick Mar 16, 2023

Dohbedoh Apr 11, 2023

olamy commented Mar 17, 2023

[JENKINS-70808] Add a specific isRestartable method that accept a sta… #596

Are you sure you want to change the base?

[JENKINS-70808] Add a specific isRestartable method that accept a sta… #596

Conversation

Dohbedoh commented Mar 16, 2023

jglick Mar 16, 2023

Choose a reason for hiding this comment

Dohbedoh Apr 11, 2023

Choose a reason for hiding this comment

olamy commented Mar 17, 2023