Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-70808] Fix isRestartable by only checking against the curren… #2416

Merged
merged 4 commits into from Mar 17, 2023
Merged

[JENKINS-70808] Fix isRestartable by only checking against the curren… #2416

merged 4 commits into from Mar 17, 2023

Conversation

Dohbedoh
Copy link
Contributor

…t node

Description

See JENKINS-70808.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@Dohbedoh Dohbedoh requested a review from a team as a code owner March 16, 2023 06:48
@Dohbedoh
Copy link
Contributor Author

cc @olamy

jglick
jglick reviewed Mar 16, 2023
View reviewed changes
...ipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineNodeImpl.java

/**
* @return the Pipeline execution
* @todo: This can be removed once https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/596 is available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/pipeline-model-definition-plugin#596 can be picked up as an incremental build so long as this downstream PR is in draft.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target branch is 1.25.5.x so we will not upgrade. sounds like a leftover of the master commit

@olamy olamy mentioned this pull request Mar 17, 2023
Closed
7 tasks
@olamy olamy merged commit 1ec0fd7 into jenkinsci:1.25.5.x Mar 17, 2023
2 of 4 checks passed
olamy pushed a commit that referenced this pull request Mar 17, 2023
@Dohbedoh @olamy
[JENKINS-70808] Fix isRestartable by only checking against the curren… (
38ea67f 
#2416)

* [JENKINS-70808] Fix isRestartable by only checking against the current node
* [JENKINS-70808] Handle restartable computation in constructor
olamy added a commit that referenced this pull request Mar 17, 2023
@olamy @Dohbedoh
[JENKINS-70808] Fix isRestartable by only checking against the curren… (
c284612 
#2416) (#2417)

* [JENKINS-70808] Fix isRestartable by only checking against the current node
* [JENKINS-70808] Handle restartable computation in constructor

Co-authored-by: Allan Burdajewicz <aburdajewicz@cloudbees.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick left review comments

@olamy olamy olamy approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@Dohbedoh @olamy @jglick