[JENKINS-30122] AbstractSynchronousNonBlockingStepExecution neglected to pick up the build’s authentication #192
Conversation
…lected to pick up the build’s authentication.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -61,21 +78,4 @@ private static synchronized ExecutorService getExecutorService() { | |||
| return executorService; | |||
| } | |||
|
|
|||
| private static class StepRunner implements Runnable { | |||
There was a problem hiding this comment.
Was it needed? I see it clearer by having the run logic inside this private inner class. It would suffice to pass the auth object in the constructor and store it in a local field.
There was a problem hiding this comment.
Seemed easier and clearer to me to use a final local variable used close to its declaration, and let javac take care of the rest.
There was a problem hiding this comment.
There's no accounting for taste... but I'll try to follow your preferred notation in the future in order to have a uniform style across the project.
There was a problem hiding this comment.
Do not worry about it, I was just editing this and found it clearer here.
|
🐝 |
|
I must wait until the build finishes to set the bee... reverting to a 🐛 until the findbugs issue is solved. |
|
🐝 |
…pExecution-authentication-JENKINS-30122 [JENKINS-30122] AbstractSynchronousNonBlockingStepExecution neglected to pick up the build’s authentication
jglick
deleted the
AbstractSynchronousNonBlockingStepExecution-authentication-JENKINS-30122
branch
JENKINS-30122
@reviewbybees esp. @amuniz