Fix broken caching handling of job renames by purging cache entry [JENKINS-38159] #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work cache invalidation for efficiency [JENKINS-38159]
|
@reviewbybees |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
jglick
approved these changes
May 30, 2017
| } | ||
| } | ||
| ConcurrentMap<String, RunExt> runMap = rc.asMap(); | ||
| for (String cacheRunId : runMap.keySet()) { // Put the Concurrent in ConcurrentMap to work for us |
There was a problem hiding this comment.
Maybe better style to use Iterator.remove.
| } | ||
| ConcurrentMap<String, RunExt> runMap = rc.asMap(); | ||
| for (String cacheRunId : runMap.keySet()) { // Put the Concurrent in ConcurrentMap to work for us | ||
| // Null-check may not be needed, but just in case of mutation by another thread |
There was a problem hiding this comment.
Would that really result in null entries??
There was a problem hiding this comment.
@jglick I hope not, but am feeling a bit cautious - plus it's easier to put the check than to prove it safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-38159 - log URLs would have to be rewritten (as well as all HAL links in JSON), so it's better to just purge the cache entry and rebuild when needed.