Skip to content

Commit

Permalink
Remove NonStandardTagHook (#416)
Browse files Browse the repository at this point in the history
  • Loading branch information
basil committed Jan 30, 2023
1 parent 8aba2af commit 2db71d8
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 231 deletions.
19 changes: 0 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,25 +176,6 @@ but only if the group ID could be inferred by other means:
either that plugin being included in the `-war`,
or no `-war` being passed but the plugin being present on the update center.

### Running the PCT for plugins not following standard tag

If a plugin does not follow the standard tagging of the Jenkins community the PCT will not be able to
find and checkout the proper code from github. For those cases the PCT provides a hook that will override the
default checkout mechanism.

This hook reads the property file [nonstandardtagplugins.properties](./plugins-compat-tester/src/main/resources/) to get the information about the tag format used for the affected plugins. Each plugin that wishes to use this mechanism
has to add a new property with the artifactId of the plugin as key and a value compatible with [String.format](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#format-java.lang.String-java.lang.Object...-) the only argument
allowed for the format string is the version to chekout.

You can also specify a minimum version for the plugin to be processed by the hook, for that you add a new entry in the aforementioned properties file with the key `artifactId-minimumVersion` and value
the lowest version of the plugin for the hook to activate, if you do that the hook will ignore any run of the plugin if the specified version is lower than the one in the properties file.

```
electricflow=cloudbees-flow-%s
electricflow-minimumVersion=1.1.8
```


## Developer Info

### Debugging PCT in Docker
Expand Down
91 changes: 0 additions & 91 deletions src/main/java/org/jenkins/tools/test/hook/NonStandardTagHook.java

This file was deleted.

5 changes: 0 additions & 5 deletions src/main/resources/nonstandardtagplugins.properties

This file was deleted.

110 changes: 0 additions & 110 deletions src/test/java/org/jenkins/tools/test/NonStandardTagHookTest.java

This file was deleted.

6 changes: 0 additions & 6 deletions src/test/resources/nonstandardtagplugins.properties

This file was deleted.

0 comments on commit 2db71d8

Please sign in to comment.