Parallel downloading (#49)

jenkinsci · Jul 25, 2019 · 4516c7e · 4516c7e
1 parent 2bc8e37
commit 4516c7e
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/...n-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java b/...n-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java
@@ -194,13 +194,13 @@ public void outputFailedPlugins() {
      * @param plugins list of plugins to download
      */
     public void downloadPlugins(List<Plugin> plugins) {
-        for (Plugin plugin : plugins) {
+        plugins.parallelStream().forEach(plugin -> {
             boolean successfulDownload = downloadPlugin(plugin);
             if (!successfulDownload) {
                 System.out.println("Unable to download " + plugin.getName() + ". Skipping...");
                 failedPlugins.add(plugin);
             }
-        }
+        });
     }
 
     /**
@@ -353,13 +353,9 @@ public void resolveDependencies(Plugin plugin) {
      * @param dependentPlugins
      */
     public void downloadDependencies(List<Plugin> dependentPlugins) {
-        for (Plugin dependency : dependentPlugins) {
+        dependentPlugins.parallelStream().filter(this::filterOptionalPlugins).forEach(dependency -> {
             String dependencyName = dependency.getName();
             VersionNumber dependencyVersion = dependency.getVersion();
-            if (dependency.getPluginOptional()) {
-                System.out.println("Skipping optional dependency " + dependencyName);
-                continue;
-            }
 
             VersionNumber installedVersion = null;
             if (installedPluginVersions.containsKey(dependencyName)) {
@@ -386,7 +382,7 @@ public void downloadDependencies(List<Plugin> dependentPlugins) {
                     System.out.println("Unable to download " + dependency.getName() + ". Skipping...");
                 }
             }
-        }
+        });
     }
 
     /**
@@ -665,4 +661,13 @@ public String getJenkinsUCLatest() {
     public void setJenkinsUCLatest(String updateCenterLatest) {
         jenkinsUcLatest = updateCenterLatest;
     }
+
+    private boolean filterOptionalPlugins(Plugin d) {
+        if (d.getPluginOptional()) {
+            System.out.println("Skipping optional dependency " + d.getName());
+            return true;
+        } else {
+            return false;
+        }
+    }
 }