Tidy up test "checkVersionCompatibilityNullTest" #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant wrapping of plugin list with ArrayList. - Don't replace System.out because the method under test does not write to System.out. - Explain why there is no assertion.
timja
reviewed
Jul 9, 2020
|
|
||
| assertEquals("", output.toString()); | ||
| //check passes if no exception is thrown | ||
| pm.checkVersionCompatibility(Arrays.asList(plugin1, plugin2)); |
There was a problem hiding this comment.
There was a problem hiding this comment.
My idea is to first clean up the tests and then replace JUnit 4 with JUnit Jupiter so that we can use the assertDoesNotThrow assertion.
There was a problem hiding this comment.
How do you feel about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to System.out.