Use AssertJ for assertions #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Jul 16, 2020
plugin-management-cli/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.assertj</groupId> | ||
| <artifactId>assertj-core</artifactId> | ||
| <version>3.16.1</version> |
There was a problem hiding this comment.
would be good to manage this version in the parent in a dependencyManagement block
as it's shared between the cli and library
There was a problem hiding this comment.
Done. I updated the commit.
Improve the readability of tests. E.g.
assertThat(actualPlugins)
.containsExactlyInAnyOrder(
new Plugin("workflow-scm-step", "2.4", null, null),
new Plugin("workflow-step-api", "2.20", null, null));
is easier to read than
List<Plugin> expectedPlugins = Arrays.asList(
new Plugin("workflow-scm-step", "2.4", null, null),
new Plugin("workflow-step-api", "2.20", null, null));
assertEquals(expectedPlugins, actualPlugins);
and also more specific because it explicitly states that the order does
not matter.
Also the messages for failing tests is more helpful than the current
one. E.g. if the assertion from above fails it prints an error like
Expecting:
<[workflow-scm-step 2.4]>
to contain exactly in any order:
<[workflow-scm-step 2.4, workflow-step-api 2.20]>
but could not find the following elements:
<[workflow-step-api 2.20]>
so that it is immediately clear that one plugin is missing.
timja
approved these changes
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the readability of tests. E.g.
is easier to read than
and also more specific because it explicitly states that the order does
not matter.
Also the messages for failing tests is more helpful than the current
one. E.g. if the assertion from above fails it prints an error like
so that it is immediately clear that one plugin is missing.