Specify the default max memory for surefire. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the max memory used by surefire will depend on the system. this however has several issues, on a machine with lots of RAM but not a huge amount spare each surefire JVM may by default try and grab 2GB of ram, causing (when concurrency > 1 is used) the build to run out of memory. 756MB was chosed as it is a multple of 256MB and was enough for a large complex project with lots of JenkinsRule type tests.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Uh, did you mean 768? |
batmat
approved these changes
Aug 7, 2017
oleg-nenashev
approved these changes
Aug 7, 2017
|
But yeah, 768 would be something more expected. Does not really matter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the max memory used by surefire will depend on the system.
This however has several issues, on a machine with lots of RAM but not a
huge amount spare each surefire JVM may by default try and grab 2GB of
ram, causing (when concurrency > 1 is used) the build to run out of
memory.
756MB was chosed as it is a multple of 256MB and was enough for a large
complex project with lots of JenkinsRule type tests.
@reviewbybees