Fix initilization potential deadlock #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/org/jenkinsci/plugins/prometheus/service/DefaultPrometheusMetrics.java
Fixed
Show fixed
Hide fixed
Dohbedoh
commented
Mar 10, 2024
src/main/java/org/jenkinsci/plugins/prometheus/service/DefaultPrometheusMetrics.java
Outdated
Show resolved
Hide resolved
Waschndolos
approved these changes
Mar 10, 2024
|
Thank you for the PR. I'll test it in our Companies Test Instance tomorrow and perform a Release the upcoming days |
|
Appears to work as before (as expected :)) |
Waschndolos
added a commit
that referenced
this pull request
Mar 28, 2024
This reverts commit d79999a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635. It should at least guarantee that loading the extension (that would call the constructor) does register the collector.
Changes proposed
@InitializerChecklist
Notify
@Waschndolos