Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing creation of service classes away from explicit guice usage #644

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Changing creation of service classes away from explicit guice usage #644

merged 1 commit into from
Mar 22, 2024

Conversation

Waschndolos
Copy link

usage to avoid duplicate instantiation of DefaultPrometheusMetrics class.

Fixes #635

@Waschndolos
Fixes #635: Changing creation of service classes away from explicit g…
4615bf3 
…uice usage to avoid duplicate instantiation of DefaultPrometheusMetrics class.
@Waschndolos Waschndolos merged commit 9401c6e into master Mar 22, 2024
26 checks passed
@Waschndolos Waschndolos deleted the bugfix/duplicate-guice-instanciation branch March 22, 2024 18:58
@Waschndolos Waschndolos added the refactoring Can be used when code refactoring was done label Mar 23, 2024
Waschndolos added a commit that referenced this pull request Mar 28, 2024
@Waschndolos
Revert "Fixes #635: Changing creation of service classes away from ex…
0943cc1 
…plicit guice usage to avoid duplicate instantiation of DefaultPrometheusMetrics class. (#644)"

This reverts commit 9401c6e.
Waschndolos added a commit that referenced this pull request Mar 29, 2024
@Waschndolos
Reverting commits which might cause startup issues on non docker inst…
fb5b95c 
…ances (#650)

* Revert "Fixes #635: Changing creation of service classes away from explicit guice usage to avoid duplicate instantiation of DefaultPrometheusMetrics class. (#644)"

This reverts commit 9401c6e.

* Revert "Fix initilization potential deadlock (#637)"

This reverts commit d79999a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Can be used when code refactoring was done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible deadlock on startup
1 participant
@Waschndolos