Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-47573] Mark extension of class from optional dependency as optional #109

Merged
merged 1 commit into from Oct 23, 2017

Conversation

dwnusbaum
Copy link
Member

@dwnusbaum dwnusbaum commented Oct 23, 2017

See JENKINS-47573.

#107 introduced an extension of RebuildValidator from the optional dependency rebuild-plugin.

This PR marks the extension as optional to prevent NoClassDefFound errors in the logs.

@reviewbybees

@ghost
Copy link

ghost commented Oct 23, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my fault, I should have noticed it during the review.

🐝 and @reviewbybees done

@oleg-nenashev oleg-nenashev merged commit a006867 into jenkinsci:master Oct 23, 2017
@dwnusbaum dwnusbaum deleted the JENKINS-47573 branch October 23, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants