[JENKINS-40803] provide a config file resolution context for promotions #113
Conversation
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>config-file-provider</artifactId> | ||
| <version>2.17.1-SNAPSHOT</version> |
There was a problem hiding this comment.
You could use "maven deploy" to deploy a timestamped snapshot for testing this PR in CI
pom.xml
Outdated
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>structs</artifactId> |
There was a problem hiding this comment.
bad idea, it's better to add explicit dependency on Structs plugin to this POM
| import org.jenkinsci.plugins.configfiles.ConfigContextResolver; | ||
|
|
||
| @Extension(optional = true) | ||
| public class JobPropertyImplConfigContextResolver extends ConfigContextResolver { |
There was a problem hiding this comment.
Add @Restricted(NoExternalUse.class)
|
Thanks for the review @oleg-nenashev |
There was a problem hiding this comment.
👍 from me. Will also request a review from @dwnusbaum, because he was interested in co-maintaining this plugin
|
Following release of 2.18 version of config-files-provider plugin, I updated the PR to use this version. |
|
@Greybird Thanks! I am planing on merging and releasing the change tonight. |
downstream proposal for jenkinsci/config-file-provider-plugin#49.
to implement solution proposed for #104