Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-7739] - Fix the failing test #64

Merged
merged 2 commits into from Aug 19, 2015

Conversation

oleg-nenashev
Copy link
Member

This change fixes a test from #57 , which has been merged. The test is flappy, becase there was no rebuild of the dependency graph. In addition, test projects have been renamed for a better readability.

@reviewbybees @FrantaM

@oleg-nenashev oleg-nenashev added this to the 2.22 milestone Aug 19, 2015
@ghost
Copy link

ghost commented Aug 19, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@FrantaM
Copy link
Contributor

FrantaM commented Aug 19, 2015

That's interesting. The test never failed on my computer.

@oleg-nenashev
Copy link
Member Author

It depends on the execution speed of background Jenkins processes. Tests in Jenkins test-harness use such approach, so I think it's a reasonable change..

E.g. https://github.com/jenkinsci/jenkins/blob/fd83a285b3b1560ba19122ff33edc522de7027f0/test/src/test/java/hudson/model/ProjectTest.java#L367-L368

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@amuniz
Copy link
Member

amuniz commented Aug 19, 2015

Yes, the dependency graph rebuild seems to be running asynchronously (see rebuildDependencyGraphAsync), so some race conditions could happen in this test.

🐝

@oleg-nenashev
Copy link
Member Author

@reviewbybees done
I'm using my maintainer's hat to go forward

oleg-nenashev added a commit that referenced this pull request Aug 19, 2015
@oleg-nenashev oleg-nenashev merged commit 84bf6f9 into jenkinsci:master Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants