Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testTestRedisConnection coverage by checking for authorization #20

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Improve testTestRedisConnection coverage by checking for authorization #20

merged 2 commits into from
Jun 24, 2020

Conversation

stellargo
Copy link
Contributor

This increases test coverage of testTestRedisConnection to check if authorization is only provided for testing redis connection to admins

@stellargo stellargo requested a review from a team as a code owner June 19, 2020 19:26
oleg-nenashev
oleg-nenashev approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@stellargo stellargo merged commit c9e3b05 into jenkinsci:master Jun 24, 2020
@stellargo stellargo deleted the test_auth branch June 24, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afalko afalko afalko approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stellargo @afalko @oleg-nenashev