Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-37565] - Really allow compiling with Java 7 #108

Merged
merged 1 commit into from Sep 26, 2016

Conversation

oleg-nenashev
Copy link
Member

Just a leftover fix

@reviewbybees

@ghost
Copy link

ghost commented Sep 26, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@stephenc
Copy link
Member

🐝

@jglick
Copy link
Member

jglick commented Sep 26, 2016

🐝 though should this not be picked up automatically from the parent POM when you set the right java.level?

@oleg-nenashev
Copy link
Member Author

though should this not be picked up automatically from the parent POM when you set the right java.level?

It should, but https://github.com/jenkinsci/pom/blob/master/pom.xml does not include Animal Sniffer at all. Maybe needs a fix

@oleg-nenashev
Copy link
Member Author

@reviewbybees done

@oleg-nenashev oleg-nenashev merged commit f0f10b0 into master Sep 26, 2016
@oleg-nenashev oleg-nenashev deleted the JENKINS-37565-animal-sniffer branch May 16, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants