Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with JEP-227 #40

Merged
merged 9 commits into from
Nov 5, 2020
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 7, 2020

Attempts to allow this plugin to run before or after JEP-227, analogous to jenkinsci/ldap-plugin#46 + jenkinsci/ldap-plugin#48.

Subsumes #38 for cleanup.

@Wadeck @oleg-nenashev @rsandell

jglick added a commit to jglick/jep that referenced this pull request Oct 7, 2020
@jglick
Copy link
Member Author

jglick commented Nov 5, 2020

@bvcelari confirms that this patch works in 2.249.2 with an LDAP configuration. Has not been tested against a Spring-based core except to the extent that the simple functional test (not using LDAP) passes.

@jglick jglick requested a review from Wadeck November 5, 2020 15:15
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed, not tested. It seems to cover well the changes from "groovy" to regular Java construction :)

I will close #38 as well, thanks!

@jglick jglick merged commit 0ca1d9e into jenkinsci:master Nov 5, 2020
@jglick jglick deleted the spring-compat branch November 5, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants