[JENKINS-45942] - Attempt to solve issue (#49)

* atempt to solve issue #45942 * atempt to solve issue #45942 * another way to same issue * storing permission in a local variable to avoid duplicate call * storing permission in a local variable to avoid duplicate call * final commit Did basic formatting suggested. * Update RoleBasedAuthorizationStrategy.java
jenkinsci · Dec 30, 2018 · a2069c1 · a2069c1
1 parent 30255ac
commit a2069c1
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/...ain/java/com/michelin/cio/hudson/plugins/rolestrategy/RoleBasedAuthorizationStrategy.java b/...ain/java/com/michelin/cio/hudson/plugins/rolestrategy/RoleBasedAuthorizationStrategy.java
@@ -292,7 +292,12 @@ public void doAddRole(@QueryParameter(required = true) String type,
 
         Set<Permission> permissionSet = new HashSet<>();
         for (String p : permissionList) {
-            permissionSet.add(Permission.fromId(p));
+            Permission temp=Permission.fromId(p);
+            if (temp == null) {
+                throw new IOException("Cannot find permission for id=" + p + ", role name=" + roleName + " role type=" + type);
+            } else {
+                permissionSet.add(temp);
+            }
         }
         Role role = new Role(roleName, pttrn, permissionSet);
         if (overwriteb) {