Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-67456] add check that pattern is valid #178

Merged
merged 3 commits into from May 30, 2022

Conversation

mawinter69
Copy link
Contributor

performs a check of the pattern when the field looses focus
Additionally check when pressing the add button if the pattern is valid to avoid that an invalid pattern can be added at all.
see JENKINS-67456

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

mawinter69 and others added 2 commits May 27, 2022 21:41
…eBasedAuthorizationStrategy.java

Co-authored-by: Abhyudaya Sharma <11471599+AbhyudayaSharma@users.noreply.github.com>
javascript has different rules so it might falsely allow or deny a
pattern
@NotMyFault NotMyFault added the bug label May 30, 2022
@NotMyFault NotMyFault merged commit 0634ce1 into jenkinsci:master May 30, 2022
@kuoruan
Copy link

kuoruan commented May 31, 2022

The escape function is deprecated https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape
Can we use encodeURIComponent instead?

@NotMyFault
Copy link
Member

The escape function is deprecated https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape Can we use encodeURIComponent instead?

Interesting, feel free to submit a new PR addressing the deprecation. I'm not a maintainer of this plugin.

@mawinter69 mawinter69 deleted the JENKINS-67456 branch June 30, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants