New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dialogs to add users and groups #342

Merged

mawinter69 merged 6 commits into jenkinsci:master from mawinter69:dialogs

Feb 29, 2024

Contributor

mawinter69 commented Nov 18, 2023 •

edited

Loading

replace the browser built-in prompt and alert with the new dialogs when adding users and groups or showing the matches for jobs and agents

some minor UI fixes for templates

Testing done

Submitter checklist

Beta Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options


          use dialogs to add users and groups

783087d

replace the browser built-in pop-ups with the new dialogs

some minor UI fixes for templates

mawinter69 requested a review from a team as a code owner

November 18, 2023 01:19

mawinter69 added 4 commits

November 18, 2023 13:49


          use modal for matching items/agents

8fcdf9b


          Merge branch 'master' into dialogs

2bae4c8


          update jenkins version and bom

21b2f4b


          Merge branch 'dialogs' of github.com:mawinter69/role-strategy-plugin …

f39251b

…into dialogs

mawinter69 added enhancement dependencies labels


          Merge branch 'master' into dialogs

06731cd

mawinter69 merged commit f33ad2c into jenkinsci:master

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment