Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Cache RoleMaps produced by RoleMap#newMatchingRoleMap() #81

Merged
merged 6 commits into from
Jun 27, 2019
Merged

Performance: Cache RoleMaps produced by RoleMap#newMatchingRoleMap() #81

merged 6 commits into from
Jun 27, 2019

Commits on Jun 20, 2019

  1. Add a cache to newMatchingRoleMap 

    Since the newMatchingRoleMap is called for every ACL request and a lot
of permissions are checked for a project when the home page loads, having
a cache avoids checking regular expressions again for every time permission
checks are called for a given Item.
    @AbhyudayaSharma
    AbhyudayaSharma committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    4139acd View commit details
    Browse the repository at this point in the history

  2. Add items to the cache

    @AbhyudayaSharma
    AbhyudayaSharma committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    86d94bd View commit details
    Browse the repository at this point in the history

  3. Invalidate cache on adding and removing role 

    * cleanup JavaDoc for newMatchingRoleMap
* remove unused private method
* cleanup unAssignRole
    @AbhyudayaSharma
    AbhyudayaSharma committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    4846f65 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. Expire cache entries after 1 hour

    @AbhyudayaSharma
    AbhyudayaSharma committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    b267c97 View commit details
    Browse the repository at this point in the history

  2. Rename itemName to itemNamePrefix

    @AbhyudayaSharma
    AbhyudayaSharma committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    7eb9afe View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Increase max cache size to 2048 objects

    @AbhyudayaSharma
    AbhyudayaSharma committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    1f9a783 View commit details
    Browse the repository at this point in the history