Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED JENKINS-42150] Add latency options to mock scm impl in SCM API's test artifact #31

Merged
merged 2 commits into from
Feb 17, 2017
Merged

[FIXED JENKINS-42150] Add latency options to mock scm impl in SCM API's test artifact #31

merged 2 commits into from
Feb 17, 2017

Conversation

stephenc
Copy link
Member

See JENKINS-42150

@reviewbybees

jglick
jglick approved these changes Feb 17, 2017
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming there is some downstream PR coming up.

src/test/java/jenkins/scm/impl/mock/MockSCMController.java Outdated
return this;
}

public MockSCMController withoutLatency() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just create a MockLatency.none() to cancel. That could also avoid null checks elsewhere.

@stephenc stephenc merged commit 3abf209 into jenkinsci:master Feb 17, 2017
@stephenc stephenc deleted the jenkins-42150 branch February 17, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenc @jglick