[FIXED JENKINS-44648] SCMRevisionAction should record corresponding source #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
jglick
approved these changes
Jun 2, 2017
| * @param revision the {@link SCMRevision}. | ||
| * @deprecated use {@link #SCMRevisionAction(SCMSource, SCMRevision)} | ||
| */ | ||
| @Restricted(DoNotUse.class) |
There was a problem hiding this comment.
@Restricted on top of @Deprecated is just superfluous. Deprecation itself suffices for the intended purpose. Restrictions should be limited to newly introduced members which for technical reasons must be public.
There was a problem hiding this comment.
I want to stop people using this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-44648
@reviewbybees