[JENKINS-29541] GString receiver handling

[jglick]

JENKINS-29541

Adding a whitelist entry for String.substring is trivial and in fact an administrator could do so for themselves. The bigger problem was with GString, whose invokeMethod is a little hack to delegate unknown methods to String; this needs special treatment. (Ideally the Groovy sandbox library would handle this sort of painful detail, but it does not.)

@reviewbybees

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[amuniz]

🐝

Out of scope: perhaps findMatchingMethod should be improved to search for the receiver method in parents hierarchy.

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[tfennelly]

🐝

[jglick]

perhaps findMatchingMethod should be improved to search for the receiver method in parents hierarchy

Well that is what method does when it calls findMatchingMethod in a loop, but (so far as I know) staticMethod does not need that, nor does method’s check for String methods on a GString.