Remove # consistently from channel name in file upload #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Aug 29, 2024
| String channel = channelName; | ||
| if (splitForThread.length == 2) { | ||
| channel = splitForThread[0]; | ||
| if (channel.startsWith("#")) { |
There was a problem hiding this comment.
previously was only removed if a thread_ts was attached which was probably more common in pipeline but not always there.
timja
commented
Aug 29, 2024
| @@ -95,6 +98,19 @@ public static String getChannelId(String botUserToken, String channelName) throw | |||
| return channelId; | |||
| } | |||
|
|
|||
| private static String cleanChannelName(String channelName) { | |||
There was a problem hiding this comment.
move to the cache so both freestyle and pipeline share the same common code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #993
Makes it so that # is removed from both freestyle and pipeline builds from the channel name so that the cache can find the appropriate channel id.
Testing done
Manually tested with freestyle job
Submitter checklist