Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-27152] Use a standardized directory for $SSH_AUTH_SOCK #11

Merged
merged 5 commits into from Mar 4, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 29, 2016

JENKINS-27152

@reviewbybees

@ghost
Copy link

ghost commented Feb 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick
Copy link
Member Author

jglick commented Feb 29, 2016

Will check test failure; do not think I get it locally.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@amuniz
Copy link
Member

amuniz commented Mar 1, 2016

Looks good, but the test fail is suspicious.

The test passes for me locally (even with some stacktraces). I can see this log line:

[sshAgentAvailableAfterRestart #1] SSH Agent before restart /tmp/jenkins2298050772070608259.jnr

But the same line (guessed by position) in the CI build log is:

[sshAgentAvailableAfterRestart #1] SSH Agent before restart /tmp/ssh1266015111258068214

@amuniz
Copy link
Member

amuniz commented Mar 1, 2016

🐝

jglick added a commit that referenced this pull request Mar 4, 2016
[JENKINS-27152] Use a standardized directory for $SSH_AUTH_SOCK
@jglick jglick merged commit f96025a into jenkinsci:master Mar 4, 2016
@jglick jglick deleted the temp-dir-JENKINS-27152 branch March 4, 2016 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants