[JENKINS-50181] add trailing newline to private keys entered in web UI to appease ssh-add

[liath]

Per JENKINS-50181.

If there's no trailing newline ssh-add will get upset and either refuse the key with Error loading key "<path>": invalid format or prompt for a password when the key does not have one and fail.

I don't know that the ternary is idiomatic, so please let me know if there's anything smelly. Ty!

[dwnusbaum]

Thanks for the PR! Changes look fine at a glance, but I think #32 needs to be finalized before the CI build will pass.

[willis7]

Keen to see this merged as hitting the same problem

[rvbmedeiros]

Does it have any estimated conclusion?

[jvz]

Code looks good, but needs to be rebased from master apparently. I don't have merge permissions here, though I can try to find someone who can.

[radepal]

Is there any chance to solve this
It is very annoying issue to automate things with JCasC

[albertorm95]

@liath Where do I need to put the new line entry? I don't get it

[liath]

When pasting the key into the web UI, you need to make sure there's a newline after the key.
So

---KEY---

needs to be:

---KEY---

[FnTm]

@liath do you think you'll fix this up and push for merge?
I'm only asking because I got bit by this today, and I'd really like to not have to remember this. Therefore if you've no time to wrap this up - I could take over the small bits left to finish.

[akoeplinger]

Just wasted a few hours today until I found this issue/PR, would be really nice if this got merged :)

[subourbonite]

Is there a reason this isn't merged? This is a huge pain. Do you need someone else to pick up this PR to get it over the finish line?

[liath]

Afaik the failing tests have nothing to do with this PR and it's ready to merge.

[lcollins]

@jglick - hi there, we have been caught by this costing us a couple of hours... wondering if this PR is in a state where it can be merged as it looks like the test has been updated per last review.

[liath]

Oh good, the tests pass now.

[jglick]

This PR got damaged by some kind of Git mistakes, as can be seen in the Commits tab. Please rebase it to one commit, or just close it and file a fresh PR with the patch recommitted.

[liath]

Yeah, that was a mess. Should be clean now :)

Force push updated

[whyman]

We just ran into this, please merge!

[jvz]

Thanks for reminding me that this was still open.

[jvz]

I'll work on a 1.17.1 release later today most likely (otherwise later this week sometime).